About 98% of all my terrible addresses have always been terrible because of aging out (nTime > ADDRMAN_HORIZON). The other conditions are almost never true.
From my own node calculation, changing ADDRMAN_RETRIES
to 1 would increase my isTerrible rate to 25%.
I wonder if the initial idea was that we need at least three unsuccessful attempts because some nodes might be offline temporarily but could come back online. If we changed this, an address comes back online, but we don’t make another attempt? In that case, the address would be at a disadvantage; maybe 2 might be a better middle ground